Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate How Repository.find_all Treats URI Escapes #8

Open
runpaint opened this issue Apr 20, 2009 · 2 comments
Open

Investigate How Repository.find_all Treats URI Escapes #8

runpaint opened this issue Apr 20, 2009 · 2 comments

Comments

@runpaint
Copy link
Contributor

The query for Repository.find_all is an Array of words concatenated with ‘+’ signs. Oddly, separating the words with percent-encoded spaces doesn’t work. What does this imply about the suitability of URI-escaping the query? We need to do something with special characters, or they’ll mess up the URL we generate. Do we just escape as normal, but replace spaces with ‘+’?

@radar
Copy link
Collaborator

radar commented Jul 31, 2009

Do you have any examples of any repositories with characters that need to be escaped?

@runpaint
Copy link
Contributor Author

IIRC, it wasn't the name of the repository, it was that .find_all took an arbitrary string then only superficially munged it before constructing the URL. While repository names are presumably limited to US-ASCII, their descriptions and author names aren't.

Sorry for not providing a test case. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants