-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlowBuilder breaks Navigator 2.0 system level routing (deep links specifically) #117
Comments
Thanks for reporting this! This is definitely a bug imo and FlowBuilder should both support deep linking itself as well as work nicely with existing packages. Are you able to share a minimal reproduction sample? Thanks! |
@felangel Sure! I'll throw something together soon. |
Hi @felangel here is a repro repop. https://github.com/artflutter/flow_builder_unilinks_bug Screen.Recording.2024-03-01.at.9.49.11.AM.mov |
Hi |
Good evening @felangel |
Hey sorry for the slow response I’ll try to take a look either today or tomorrow 👍 |
Describe the bug
Not sure if this is a "defect" of flow_builder, but it might be worth mentioning in the docs.
Using FlowBuilder alongside AutoRoute (and probably any Navigator 2.0 based solution) will break deep linking. This is because flow_builder sets its own handler for the
SystemNavigation.instance
method channel thus hijacking all system level routing calls (didPopRoute, didPushRoute, etc).To Reproduce
Steps to reproduce the behavior:
xcrun simctl openurl booted https://{your-domain}/
)deepLinkBuilder callback isn't ran
)Expected behavior
Not sure. If FlowBuilder isn't supposed to be used with Navigator 2.0 routing packages then I think it should be mentioned in the documentation or README. If we want it to be able to coexist with Navigator 2.0 routing packages then I would expect FlowBuilder to not interfere/break them.
Additional context
I have only tested this with AutoRouter and have confirmed the issue (and that removing FlowBuilder fixes it).
The text was updated successfully, but these errors were encountered: