Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlowBuilder breaks Navigator 2.0 system level routing (deep links specifically) #117

Open
pstromberg98 opened this issue Nov 29, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@pstromberg98
Copy link

pstromberg98 commented Nov 29, 2023

Describe the bug
Not sure if this is a "defect" of flow_builder, but it might be worth mentioning in the docs.

Using FlowBuilder alongside AutoRoute (and probably any Navigator 2.0 based solution) will break deep linking. This is because flow_builder sets its own handler for the SystemNavigation.instance method channel thus hijacking all system level routing calls (didPopRoute, didPushRoute, etc).

To Reproduce
Steps to reproduce the behavior:

  1. Set up project with AutoRoute
  2. Set up deep linking (https://docs.flutter.dev/ui/navigation/deep-linking)
  3. Set initial route to contain a FlowBuilder widget
  4. Try to deep link to app in foreground (xcrun simctl openurl booted https://{your-domain}/)
  5. AutoRoute doesn't receive deep link (deepLinkBuilder callback isn't ran)

Expected behavior
Not sure. If FlowBuilder isn't supposed to be used with Navigator 2.0 routing packages then I think it should be mentioned in the documentation or README. If we want it to be able to coexist with Navigator 2.0 routing packages then I would expect FlowBuilder to not interfere/break them.

Additional context
I have only tested this with AutoRouter and have confirmed the issue (and that removing FlowBuilder fixes it).

Screenshot 2023-11-28 at 5 31 55 PM

@felangel
Copy link
Owner

Thanks for reporting this! This is definitely a bug imo and FlowBuilder should both support deep linking itself as well as work nicely with existing packages. Are you able to share a minimal reproduction sample? Thanks!

@felangel felangel added bug Something isn't working waiting for response Waiting for additional information labels Nov 29, 2023
@felangel felangel self-assigned this Nov 29, 2023
@pstromberg98
Copy link
Author

@felangel Sure! I'll throw something together soon.

@vasilich6107
Copy link

vasilich6107 commented Mar 1, 2024

Hi @felangel here is a repro repop.
Check the uri text at the top of the screen
After opening the flow page - universal links are not woking anymore

https://github.com/artflutter/flow_builder_unilinks_bug

Screen.Recording.2024-03-01.at.9.49.11.AM.mov

@vasilich6107
Copy link

vasilich6107 commented Mar 9, 2024

Hi
@felangel could you take a look

@vasilich6107
Copy link

Good evening @felangel
It would be nice to get a response
Thanks

@felangel
Copy link
Owner

Good evening @felangel
It would be nice to get a response
Thanks

Hey sorry for the slow response I’ll try to take a look either today or tomorrow 👍

@felangel felangel removed the waiting for response Waiting for additional information label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants