Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the ingestion of RSNA Spine Fracture Test Images #946

Open
dankleeman opened this issue Aug 10, 2022 · 4 comments
Open

Allow the ingestion of RSNA Spine Fracture Test Images #946

dankleeman opened this issue Aug 10, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@dankleeman
Copy link

馃殌 Feature
The RSNA Spine Fracture class is hard-coded to only load the training images: https://github.com/fepegar/torchio/blob/main/src/torchio/datasets/rsna_spine_fracture.py#L71

I propose implementing an argument at initialization to allow this class to ingest test images as well. I see this available in another similar class here: https://github.com/fepegar/torchio/blob/main/src/torchio/datasets/rsna_miccai.py#L61

Motivation

I think this would help this library be even more useful than it already is for the currently ongoing kaggle competition associated with this class.

Pitch

I think this is a relatively small change and I would like to make it. I am opening this issue to solicit comments. If there is no major opposition I'll open a PR for this later this evening after reading the contributing instructions.

Alternatives

None

Additional context

None

@dankleeman dankleeman added the enhancement New feature or request label Aug 10, 2022
@fepegar
Copy link
Owner

fepegar commented Aug 10, 2022

Hi, @dankleeman. I was planning to implement this but then noticed that there are only three test subjects. That's why the split_namevariable exists. Feel free to open a PR if you think it's worth it.

@dankleeman
Copy link
Author

Thanks for the quick reply!

I'll take a look at that variable and see if I still can come up with something that adds value. If not I'll just close this as resolved.

Cheers!

@osbm
Copy link

osbm commented Oct 12, 2022

there are three subjects, but those are for testing your pipeline. This way real dataset won't be visible to contestants but will be visible to your kaggle notebook, please add it. So it will be super useful in making submissions.

@fepegar
Copy link
Owner

fepegar commented Nov 13, 2022

please add it

Hi, @osbm. I don't have time to work on this at the moment. Please feel free to open a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants