Skip to content
This repository has been archived by the owner on Mar 19, 2018. It is now read-only.

Issues with Inputs with Encoded Entities and HTML Attributes #5

Open
nat4tq opened this issue Feb 8, 2018 · 0 comments
Open

Issues with Inputs with Encoded Entities and HTML Attributes #5

nat4tq opened this issue Feb 8, 2018 · 0 comments

Comments

@nat4tq
Copy link

nat4tq commented Feb 8, 2018

Hi,

I was testing the filter against a set of XSS test inputs. It seems that your filter is still vulnerable to XSS such as with inputs that contain XSS payloads in the HTML tags. Examples are:

<a href="jAvAsCrIpT&colon;alert&lpar;1&rpar;">X</a>
<img src=xx:xx" on error="alert(1);">, where it filters the on error="alert(1);" but not the <img src=xx:xx".

I kindly suggest that the whitelist used by the filter restricts tags with these attributes and events to make it more robust against XSS. Also, due to the Integer.decode() API, the filter outputs an error with inputs that contain #09, for example:
<A HREF="h tt p://6&#09;6.000146.0x7.147/">XSS</A>

A full report can be read in our paper, "Assessment of Dynamic Open-source Cross-site Scripting Filters as Security Devices in Web Applications".

Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant