Fix docs unnecessarily undergo limbo resolution while resuming query bug #5506

milaGGL · 2023-11-02T17:39:05Z

Ported from : firebase/firebase-js-sdk#7740

github-actions · 2023-11-02T17:39:22Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

github-actions · 2023-11-02T17:49:59Z

Unit Test Results

  180 files +  177   180 suites +177 3m 37s ⏱️ + 3m 25s
1 222 tests +1 203 1 206 ✔️ +1 187 16 💤 +16 0 ❌ ±0
2 468 runs +2 449 2 436 ✔️ +2 417 32 💤 +32 0 ❌ ±0

Results for commit 9189965. ± Comparison against base commit 8a7621b.

This pull request removes 19 and adds 1222 tests. Note that renamed tests count towards both.

com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testconvertInputStreamToString_worksSuccessfully
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsNullWhenUuidIsNull
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsProperBytes
…

com.google.firebase.TimestampTest ‑ testCompare
com.google.firebase.TimestampTest ‑ testFromDate
com.google.firebase.TimestampTest ‑ testRejectBadDates
com.google.firebase.TimestampTest ‑ testTimestampParcelable
com.google.firebase.firestore.AggregateQuerySnapshotTest ‑ createWithCountShouldReturnInstanceWithTheGivenQueryAndCount
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
…

♻️ This comment has been updated with latest results.

google-oss-bot · 2023-11-02T17:54:01Z

Size Report ¹

Affected Products

firebase-firestore
Type Base (8a7621b) Merge (adb338b) Diff
aar 1.41 MB 1.41 MB +159 B (+0.0%)
apk (release) 11.2 MB 11.2 MB +132 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/yjDybxLvby.html

google-oss-bot · 2023-11-02T18:11:05Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (8a7621b) and the CI merge commit (adb338b)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 8a7621b: https://storage.googleapis.com/firebase-sdk-metric-reports/msS31ii2qz/index.html
- adb338b: https://storage.googleapis.com/firebase-sdk-metric-reports/OXHG4YN692/index.html

Startup Times

`fire-fst`

Device Statistics Distributions

oriole-32

Percentile	`8a7621b`	`adb338b`	Diff	Significant (?)
p10	470 ±233 μs	417 ±208 μs	-53.0 μs (-11.3%)	NO
p25	485 ±236 μs	435 ±207 μs	-50.2 μs (-10.4%)	NO
p50	515 ±241 μs	483 ±198 μs	-32.2 μs (-6.2%)	NO
p75	573 ±234 μs	561 ±182 μs	-11.9 μs (-2.1%)	NO
p90	641 ±220 μs	702 ±208 μs	+61.5 μs (+9.6%)	NO

20 test runs in comparison

Commit	Test Runs
`8a7621b`	2023-11-17_03:58:16.785409_xgZQ 2023-11-17_03:58:16.785445_tHTY 2023-11-17_03:58:16.785456_kFmq 2023-11-17_03:58:16.785464_wTNg 2023-11-17_03:58:16.785469_OBOn 2023-11-17_03:58:16.785474_BTcR 2023-11-17_03:58:16.785478_Sjdv 2023-11-17_03:58:16.785482_MaMp 2023-11-17_03:58:16.785486_ztcT 2023-11-17_03:58:16.785490_fNCE
`adb338b`	2023-11-20_16:37:42.894783_qviA 2023-11-20_16:37:42.894814_WFsi 2023-11-20_16:37:42.894821_fEXX 2023-11-20_16:37:42.894825_UiQy 2023-11-20_16:37:42.894830_TFMH 2023-11-20_16:37:42.894835_Zcdv 2023-11-20_16:37:42.894839_IGwi 2023-11-20_16:37:42.894843_NWoM 2023-11-20_16:37:42.894851_BzYI 2023-11-20_16:37:42.894860_GDLS

redfin-30

Percentile	`8a7621b`	`adb338b`	Diff	Significant (?)
p10	757 ±247 μs	759 ±260 μs	+1.92 μs (+0.3%)	NO
p25	775 ±244 μs	779 ±258 μs	+3.80 μs (+0.5%)	NO
p50	803 ±239 μs	812 ±252 μs	+8.23 μs (+1.0%)	NO
p75	878 ±258 μs	850 ±248 μs	-27.8 μs (-3.2%)	NO
p90	931 ±265 μs	902 ±245 μs	-28.3 μs (-3.0%)	NO

20 test runs in comparison

Commit	Test Runs
`8a7621b`	2023-11-17_03:58:16.785409_xgZQ 2023-11-17_03:58:16.785445_tHTY 2023-11-17_03:58:16.785456_kFmq 2023-11-17_03:58:16.785464_wTNg 2023-11-17_03:58:16.785469_OBOn 2023-11-17_03:58:16.785474_BTcR 2023-11-17_03:58:16.785478_Sjdv 2023-11-17_03:58:16.785482_MaMp 2023-11-17_03:58:16.785486_ztcT 2023-11-17_03:58:16.785490_fNCE
`adb338b`	2023-11-20_16:37:42.894783_qviA 2023-11-20_16:37:42.894814_WFsi 2023-11-20_16:37:42.894821_fEXX 2023-11-20_16:37:42.894825_UiQy 2023-11-20_16:37:42.894830_TFMH 2023-11-20_16:37:42.894835_Zcdv 2023-11-20_16:37:42.894839_IGwi 2023-11-20_16:37:42.894843_NWoM 2023-11-20_16:37:42.894851_BzYI 2023-11-20_16:37:42.894860_GDLS

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`8a7621b`	`adb338b`	Diff	Significant (?)
p10	203 ±3 ms	207 ±2 ms	+3.98 ms (+2.0%)	NO
p25	209 ±3 ms	212 ±2 ms	+3.28 ms (+1.6%)	NO
p50	217 ±3 ms	220 ±2 ms	+3.40 ms (+1.6%)	NO
p75	225 ±3 ms	230 ±3 ms	+5.61 ms (+2.5%)	NO
p90	233 ±3 ms	245 ±8 ms	+11.3 ms (+4.8%)	NO

20 test runs in comparison

Commit	Test Runs
`8a7621b`	2023-11-17_03:58:16.785409_xgZQ 2023-11-17_03:58:16.785445_tHTY 2023-11-17_03:58:16.785456_kFmq 2023-11-17_03:58:16.785464_wTNg 2023-11-17_03:58:16.785469_OBOn 2023-11-17_03:58:16.785474_BTcR 2023-11-17_03:58:16.785478_Sjdv 2023-11-17_03:58:16.785482_MaMp 2023-11-17_03:58:16.785486_ztcT 2023-11-17_03:58:16.785490_fNCE
`adb338b`	2023-11-20_16:37:42.894783_qviA 2023-11-20_16:37:42.894814_WFsi 2023-11-20_16:37:42.894821_fEXX 2023-11-20_16:37:42.894825_UiQy 2023-11-20_16:37:42.894830_TFMH 2023-11-20_16:37:42.894835_Zcdv 2023-11-20_16:37:42.894839_IGwi 2023-11-20_16:37:42.894843_NWoM 2023-11-20_16:37:42.894851_BzYI 2023-11-20_16:37:42.894860_GDLS

redfin-30

Percentile	`8a7621b`	`adb338b`	Diff	Significant (?)
p10	247 ±5 ms	273 ±4 ms	+25.5 ms (+10.3%)	YES
p25	253 ±5 ms	280 ±4 ms	+26.2 ms (+10.3%)	YES
p50	261 ±4 ms	288 ±4 ms	+26.9 ms (+10.3%)	YES
p75	270 ±5 ms	299 ±5 ms	+28.5 ms (+10.5%)	YES
p90	279 ±7 ms	314 ±9 ms	+34.7 ms (+12.4%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`8a7621b`	2023-11-17_03:58:16.785409_xgZQ 2023-11-17_03:58:16.785445_tHTY 2023-11-17_03:58:16.785456_kFmq 2023-11-17_03:58:16.785464_wTNg 2023-11-17_03:58:16.785469_OBOn 2023-11-17_03:58:16.785474_BTcR 2023-11-17_03:58:16.785478_Sjdv 2023-11-17_03:58:16.785482_MaMp 2023-11-17_03:58:16.785486_ztcT 2023-11-17_03:58:16.785490_fNCE
`adb338b`	2023-11-20_16:37:42.894783_qviA 2023-11-20_16:37:42.894814_WFsi 2023-11-20_16:37:42.894821_fEXX 2023-11-20_16:37:42.894825_UiQy 2023-11-20_16:37:42.894830_TFMH 2023-11-20_16:37:42.894835_Zcdv 2023-11-20_16:37:42.894839_IGwi 2023-11-20_16:37:42.894843_NWoM 2023-11-20_16:37:42.894851_BzYI 2023-11-20_16:37:42.894860_GDLS

https://storage.googleapis.com/firebase-sdk-metric-reports/z7dhbe7TMA/index.html

google-oss-bot · 2023-11-02T18:51:48Z

Coverage Report ¹

Affected Products

firebase-firestore
Overall coverage changed from 44.75% (8a7621b) to 44.76% (adb338b) by +0.01%.
Filename Base (8a7621b) Merge (adb338b) Diff
SyncEngine.java 93.31% 93.38% +0.06%
View.java 96.79% 96.82% +0.02%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/ySExgUtsZR.html

dconeybe

Wonderful!

dconeybe

Oh, please add a change log entry.

initial code

a551409

google-oss-bot added the size/M label Nov 2, 2023

milaGGL added the no-changelog label Nov 2, 2023

milaGGL added 3 commits November 3, 2023 11:41

format

a7dd39a

Merge branch 'master' into mila/fix-limbo-bug

7518555

Update limbo_spec_test.json

35ab54c

google-oss-bot added size/L and removed size/M labels Nov 6, 2023

milaGGL added 4 commits November 7, 2023 09:46

Merge branch 'master' into mila/fix-limbo-bug

1b6e457

Merge branch 'master' into mila/fix-limbo-bug

c7d3ca9

Merge branch 'master' into mila/fix-limbo-bug

fb00976

port changes in web PR

866ee3b

milaGGL requested a review from dconeybe November 14, 2023 15:04

milaGGL assigned milaGGL and dconeybe and unassigned milaGGL Nov 14, 2023

Merge branch 'master' into mila/fix-limbo-bug

0ae72d6

dconeybe mentioned this pull request Nov 16, 2023

Fix docs unnecessarily undergo limbo resolution while resuming query bug firebase/firebase-js-sdk#7740

Merged

4 tasks

dconeybe approved these changes Nov 16, 2023

View reviewed changes

dconeybe assigned milaGGL and unassigned dconeybe Nov 16, 2023

dconeybe requested changes Nov 16, 2023

View reviewed changes

milaGGL added 2 commits November 20, 2023 11:23

Update CHANGELOG.md

6d03601

Merge branch 'master' into mila/fix-limbo-bug

9189965

milaGGL removed the no-changelog label Nov 20, 2023

milaGGL requested a review from dconeybe November 20, 2023 20:49

dconeybe approved these changes Nov 21, 2023

View reviewed changes

milaGGL merged commit a014114 into master Nov 21, 2023
25 checks passed

milaGGL deleted the mila/fix-limbo-bug branch November 21, 2023 18:15

firebase locked and limited conversation to collaborators Dec 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix docs unnecessarily undergo limbo resolution while resuming query bug #5506

Fix docs unnecessarily undergo limbo resolution while resuming query bug #5506

milaGGL commented Nov 2, 2023 •

edited

github-actions bot commented Nov 2, 2023 •

edited

github-actions bot commented Nov 2, 2023 •

edited

google-oss-bot commented Nov 2, 2023 •

edited

`firebase-firestore`

google-oss-bot commented Nov 2, 2023 •

edited

`fire-fst`

`timeToInitialDisplay`

google-oss-bot commented Nov 2, 2023 •

edited

`firebase-firestore`

dconeybe left a comment

dconeybe left a comment

Fix docs unnecessarily undergo limbo resolution while resuming query bug #5506

Fix docs unnecessarily undergo limbo resolution while resuming query bug #5506

Conversation

milaGGL commented Nov 2, 2023 • edited

github-actions bot commented Nov 2, 2023 • edited

📝 PRs merging into main branch

github-actions bot commented Nov 2, 2023 • edited

Unit Test Results

google-oss-bot commented Nov 2, 2023 • edited

Size Report 1

Affected Products

firebase-firestore

Test Logs

google-oss-bot commented Nov 2, 2023 • edited

Startup Time Report 1

Notes

Startup Times

fire-fst

timeToInitialDisplay

google-oss-bot commented Nov 2, 2023 • edited

Coverage Report 1

Affected Products

firebase-firestore

Test Logs

dconeybe left a comment

Choose a reason for hiding this comment

dconeybe left a comment

Choose a reason for hiding this comment

milaGGL commented Nov 2, 2023 •

edited

github-actions bot commented Nov 2, 2023 •

edited

github-actions bot commented Nov 2, 2023 •

edited

google-oss-bot commented Nov 2, 2023 •

edited

Size Report ¹

`firebase-firestore`

google-oss-bot commented Nov 2, 2023 •

edited

Startup Time Report ¹

`fire-fst`

`timeToInitialDisplay`

google-oss-bot commented Nov 2, 2023 •

edited

Coverage Report ¹

`firebase-firestore`