Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firebase init functions runtime Node 12 -> Node 14 #3399

Merged
merged 8 commits into from May 25, 2021
Merged

Conversation

jhuleatt
Copy link
Contributor

Description

Updates the runtime for functions generated by the firebase init functions CLI command now that Node 14 is GA in Cloud Functions.

Also updates the firebase-functions and firebase-admin packages to their latest versions.

Scenarios Tested

firebase init functions

the resulting functions/package.json:

{
  "name": "functions",
  "description": "Cloud Functions for Firebase",
  "scripts": {
    "serve": "firebase emulators:start --only functions",
    "shell": "firebase functions:shell",
    "start": "npm run shell",
    "deploy": "firebase deploy --only functions",
    "logs": "firebase functions:log"
  },
  "engines": {
    "node": "14"
  },
  "main": "index.js",
  "dependencies": {
    "firebase-admin": "^9.8.0",
    "firebase-functions": "^3.14.1"
  },
  "devDependencies": {
    "firebase-functions-test": "^0.2.0"
  },
  "private": true
}

Docs

This affects the docs here:

Screen Shot 2021-05-24 at 5 11 03 PM

@jhuleatt jhuleatt requested review from joehan and egilmorez May 24, 2021 21:11
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label May 24, 2021
@joehan
Copy link
Contributor

joehan commented May 25, 2021

Thanks for making these changes - this reminds me that I should do the same for ext:dev:init templates

@jhuleatt jhuleatt merged commit cfb1e51 into master May 25, 2021
@ghost
Copy link

ghost commented May 27, 2021

Does it mean that Node 14 is no longer in beta?

2021-05-27_080018

@jhuleatt
Copy link
Contributor Author

jhuleatt commented May 27, 2021

@web2033 yes, we'll be updating that doc soon

devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
@bkendall bkendall deleted the jhuleatt-node-14 branch March 18, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants