Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proc/pid completion in OS X #129

Closed
wants to merge 1 commit into from

Conversation

bobthecow
Copy link

No description provided.

@ridiculousfish
Copy link
Member

I'd love to get these completions working with OS X, but I see a few problems with these changes:

  • pgrep is not installed by default on OS X
  • __fish_complete_proc doesn't seem to return many processes. (I think you need to pass -x to ps)

Please address these, and I'll be glad to merge.

@bobthecow
Copy link
Author

Now that it's the future, both of your concerns should have been resolved. Can we merge it now? :)

@ridiculousfish
Copy link
Member

I ended up fixing these a different way. Commit is 6416cb4

@bobthecow
Copy link
Author

Sweet :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants