Tab completion preview thrown off track by unicode filenames

[mikaeleiman]

Example:

mikaeleiman@Berit ~/temp> ls
C#.tmbundle          jlink-test           s3stats
dmtp                 libusb-0.1.12.tar.gz
dmtp_corp            namnlös mapp
mikaeleiman@Berit ~/temp> cd namnlös mapp/
mikaeleiman@Berit ~/temp> cd ammnlös mapp/

I have a dir with a name containing a multi-byte UTF8 character, "namnlös mapp". When I type "cd n", the rest of the name is auto-complete-previewed (yay!). However, instead of the insert point being on "a", as you would expect, it's been moved back to "n". So when I type the second letter of the name, it overwrites the first letter, resulting in the last line of the example.

[ridiculousfish]

Reproduces for me on OS X

[ridiculousfish]

wcwidth() does the wrong thing for combining characters. It's discussed at http://www.zsh.org/mla/workers/2008/msg00503.html

[ridiculousfish]

The deeper problem is that fish has no way of representing that a zero-width character has been output, so the combining marks can get lost very easily.

I rewrote the line representation here to add support. That should fix this.

To git@github.com:fish-shell/fish-shell.git
b1281c3..ea1bfd7 master -> master