Add termux support for fish_config. #6248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krobelus
reviewed
Oct 25, 2019
share/tools/web_config/webconfig.py
Outdated
| @@ -49,6 +49,10 @@ def is_wsl(): | |||
| return True | |||
| return False | |||
|
|
|||
| def is_termux(): | |||
| """ Return whether we are running under the Terumx application for Android""" | |||
share/tools/web_config/webconfig.py
Outdated
| @@ -49,6 +49,10 @@ def is_wsl(): | |||
| return True | |||
| return False | |||
|
|
|||
| def is_termux(): | |||
| """ Return whether we are running under the Terumx application for Android""" | |||
| return 'com.termux' in os.environ['PATH'] and 0 == os.system('which termux-open-url 1>&2 2>/dev/null') | |||
There was a problem hiding this comment.
which termux-open-url 1>&2 2>/dev/null will send stdout to stderr and stderr to /dev/null.
If you want to discard both, swap the order of the redirection operators.
There was a problem hiding this comment.
Also this check itself is really quite.... unclean, and invokes another shell and the which command, which doesn't have to be installed and should be discouraged (in shell scripts, use command -v).
I'd suggest distutils.spawn.find_executable('termux-open-url'), which returns a path if it finds it and None if it doesn't.
There was a problem hiding this comment.
using distutils instead of which
Liorst4
force-pushed
the
fish-config-termux
branch
from
df3e012
to
f55462f
Compare
Liorst4
force-pushed
the
fish-config-termux
branch
from
f55462f
to
a1d85ef
Compare
|
This looks much nicer now. Merged, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.