Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Events of close relatives' only listed for first associate #1192

Closed
ric2016 opened this issue Jan 22, 2017 · 8 comments
Closed

'Events of close relatives' only listed for first associate #1192

ric2016 opened this issue Jan 22, 2017 · 8 comments
Labels
bug confirmed bug gedcom handling of GEDCOM data

Comments

@ric2016
Copy link
Contributor

ric2016 commented Jan 22, 2017

This bug has been discussed as while ago in https://www.webtrees.net/index.php/en/forum/help-for-ver-1-7-4/31323-how-to-add-other-kind-of-related-person, but apparently not reported here:

On the 'Facts and Events' tab, in the list of 'Events of close relatives' of an Individual Ix, an associate event is only displayed if Ix is listed as the first associate of the respective event (e.g. as the first godparent).

This is because associateFacts in IndividualFactsTabModule.php only checks for the first attribute ($fact->getAttribute('_ASSO')/$fact->getAttribute('ASSO')). Here, all ASSO/_ASSO attributes should be used instead, e.g. via a new function in Fact.php:

public function getAttributes($tag) {
	preg_match_all('/\n2 (?:' . $tag . ') ?(.*(?:(?:\n3 CONT ?.*)*)*)/', $this->gedcom, $matches);
	$attributes = array();
	foreach ($matches[1] as $match) {
		$attributes[] = preg_replace("/\n3 CONT ?/", "\n", $match);
	}
	return $attributes;
}
@fisharebest fisharebest added bug confirmed bug gedcom handling of GEDCOM data labels Jul 18, 2017
@apberger
Copy link

Is there any idea, when this issue will be solved?

@Joppla
Copy link
Contributor

Joppla commented Sep 14, 2018

This item is closed, but the bug is not solved in v 1.7.11

@ric2016
Copy link
Contributor Author

ric2016 commented Sep 14, 2018

Where do you see that this issue is closed?

@fisharebest
Copy link
Owner

This item is closed

This issue is not closed. Issue #1267 is closed, and #1267 has a reference to this issue.

@Joppla
Copy link
Contributor

Joppla commented Sep 14, 2018

misunderstanding, sorry, in the title I saw "close" and here also:
afbeelding
But now I understand that it is a link to the other item.

Any idea when the item will be solved?

@AndreasRauhut
Copy link
Contributor

Me too, I would like that somebody will do the neccessary to solve the bug and close the issue.
Unfortunately I'm not the right person to do it.

@AndreasRauhut
Copy link
Contributor

Please explain me, why I can't see a change in the behavior of my database. I understood that you changed the code and closed the issue, but I see only one chagement.
When I place relationships in webtrees, the system creates an _ASSO tag instead of an ASSO tag.

But nevetheless only the first relative of a person will show the relationship to this person.
Does I need to change some code or wait for the next release ?
Please give me a hint.

@fisharebest
Copy link
Owner

You asked the same question on the fourm.
I gave examples showing that the code is now fixed.

Please give me a hint.

You must give me a hint.
Show me an example where it is not working.
Perhaps you have a different problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed bug gedcom handling of GEDCOM data
Projects
None yet
Development

No branches or pull requests

5 participants