Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

maintenance show --remaining does not work as expected #887

Open
jessereynolds opened this issue Jul 13, 2015 · 0 comments
Open

maintenance show --remaining does not work as expected #887

jessereynolds opened this issue Jul 13, 2015 · 0 comments
Labels
Milestone

Comments

@jessereynolds
Copy link
Member

I would expect the meaning of --remaining [duration] to mean:

  • is currently in maintenance
  • maintenance ends in the next [duration] time

However it seems it just means:

  • maintenance ends in the next [duration] time

because I'm getting a lot of past maintenances when I use this flag.

The online help doesn't differentiate between --finish and --remaining either. From the output of flapjack1dev maintenance show --help:

    --finish, --finished, --finishing, --remain, --remained, --remaining, --end, -f arg - 
  The finishing time for
  the maintenance window,
  eg 'more than 1 year
  from now'. This should
  be prefixed with 'more
  than', 'less than',
  'on', 'before', or
  'after', or of the form
  'between time and time'
  (default: none)

I think we should handle --remaining differently from --finish. The former takes different arguments anyway - a duration as opposed to a fixed time. The word "remaining" also implies the maintenance is current.

For 2.0 we should either fix this or remove the --remaining option.

@jessereynolds jessereynolds added this to the 1.x milestone Jul 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant