You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 15, 2024. It is now read-only.
I would expect the meaning of --remaining [duration] to mean:
is currently in maintenance
maintenance ends in the next [duration] time
However it seems it just means:
maintenance ends in the next [duration] time
because I'm getting a lot of past maintenances when I use this flag.
The online help doesn't differentiate between --finish and --remaining either. From the output of flapjack1dev maintenance show --help:
--finish, --finished, --finishing, --remain, --remained, --remaining, --end, -f arg -
The finishing time for
the maintenance window,
eg 'more than 1 year
from now'. This should
be prefixed with 'more
than', 'less than',
'on', 'before', or
'after', or of the form
'between time and time'
(default: none)
I think we should handle --remaining differently from --finish. The former takes different arguments anyway - a duration as opposed to a fixed time. The word "remaining" also implies the maintenance is current.
For 2.0 we should either fix this or remove the --remaining option.
The text was updated successfully, but these errors were encountered:
I would expect the meaning of
--remaining [duration]
to mean:However it seems it just means:
because I'm getting a lot of past maintenances when I use this flag.
The online help doesn't differentiate between --finish and --remaining either. From the output of
flapjack1dev maintenance show --help
:I think we should handle
--remaining
differently from--finish
. The former takes different arguments anyway - a duration as opposed to a fixed time. The word "remaining" also implies the maintenance is current.For 2.0 we should either fix this or remove the
--remaining
option.The text was updated successfully, but these errors were encountered: