Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

flapjack crashes on wrong regex in rules #921

Open
slune opened this issue Nov 25, 2015 · 3 comments
Open

flapjack crashes on wrong regex in rules #921

slune opened this issue Nov 25, 2015 · 3 comments

Comments

@slune
Copy link

slune commented Nov 25, 2015

2015-11-24T23:20:06.447241-08:00 [DEBUG] :: flapjack-notifier :: considering rule with entities: , entities regex: [],
                           tags: null and regex tags: "#<Set:0x000000025feb30>"
/opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/flapjack-1.4.0/lib/flapjack/data/notification_rule.rb:158:in `block (2 levels) in match_regex_tags?': target of repeat operator is not specified: /*puppet*/ (RegexpError)
        from /opt/flapjack/embedded/lib/ruby/2.1.0/set.rb:263:in `each_key'
        from /opt/flapjack/embedded/lib/ruby/2.1.0/set.rb:263:in `each'
        from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/flapjack-1.4.0/lib/flapjack/data/notification_rule.rb:157:in `block in match_regex_tags?'
        from /opt/flapjack/embedded/lib/ruby/2.1.0/set.rb:263:in `each_key'
        from /opt/flapjack/embedded/lib/ruby/2.1.0/set.rb:263:in `each'
        from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/flapjack-1.4.0/lib/flapjack/data/notification_rule.rb:156:in `match_regex_tags?'
        from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/flapjack-1.4.0/lib/flapjack/data/notification.rb:153:in `block (2 levels) in messages'
        from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/flapjack-1.4.0/lib/flapjack/data/notification.rb:144:in `select'
        from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/flapjack-1.4.0/lib/flapjack/data/notification.rb:144:in `block in messages'
        from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/flapjack-1.4.0/lib/flapjack/data/notification.rb:129:in `collect'
        from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/flapjack-1.4.0/lib/flapjack/data/notification.rb:129:in `messages'
        from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/flapjack-1.4.0/lib/flapjack/notifier.rb:106:in `process_notification'
        from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/flapjack-1.4.0/lib/flapjack/notifier.rb:69:in `start'
        from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/flapjack-1.4.0/lib/flapjack/pikelet.rb:126:in `block in start'
@jessereynolds
Copy link
Member

@slune does this occur in the latest stable version, 1.6.0 ? 1.4.0 is fairly old... 1.6.0 contains this PR that has work on the notification rule regex matchers: #871

@slune
Copy link
Author

slune commented Jan 12, 2016

@jessereynolds tested on 1.6.0 and flapjack did not crashed.

@jessereynolds
Copy link
Member

jessereynolds commented Jan 17, 2016 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants