Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure fails to find oneDNN #1088

Open
yurivict opened this issue Mar 15, 2023 · 4 comments
Open

configure fails to find oneDNN #1088

yurivict opened this issue Mar 15, 2023 · 4 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@yurivict
Copy link

Bug Description

CMake Warning at flashlight/fl/tensor/backend/onednn/CMakeLists.txt:6 (find_package):
  Could not find a configuration file for package "DNNL" that is compatible
  with requested version "2.5.2".

  The following configuration files were considered but not accepted:

    /usr/local/lib/cmake/dnnl/dnnl-config.cmake, version: 3.0.1

Call Stack (most recent call first):
  flashlight/fl/tensor/CMakeLists.txt:45 (include)
  flashlight/fl/CMakeLists.txt:32 (include)
  CMakeLists.txt:181 (include)


CMake Error at flashlight/fl/tensor/backend/onednn/CMakeLists.txt:8 (message):
  oneDNN required to build oneDNN backend: oneDNN was not found
Call Stack (most recent call first):
  flashlight/fl/tensor/CMakeLists.txt:45 (include)
  flashlight/fl/CMakeLists.txt:32 (include)
  CMakeLists.txt:181 (include)

Reproduction Steps

Regular configure.

Platform and Hardware

FreeBSD 13.1

Additional Context

Version: 0.4.0
onednn-3.0.1 (latest version)
clang-14

@yurivict yurivict added the bug Something isn't working label Mar 15, 2023
@jacobkahn
Copy link
Member

@yurivict oneDNN breaks their API with new releases -- I'm working on supporting 3.0+. Thanks for reporting.

@jacobkahn jacobkahn self-assigned this Mar 15, 2023
@vpirogov
Copy link

oneDNN follows semantic versioning. API breaks only between major versions. Minor versions are API compatible.

@tlyong3
Copy link

tlyong3 commented May 10, 2023

@jacobkahn any update on your fix for oneDNN 3.x support? I forced it to build with v3.0 or 3.1 but getting many errors such as this:
/root/flashlight/flashlight/fl/tensor/backend/onednn/OneDnnBackend.cpp:180:18: error: ‘const struct dnnl::memory::desc’ has no member named ‘data_type’; did you mean ‘get_data_type’?
180 | lhsMemDesc.data_type(), rhsMemDesc.data_type()));
| ^~~~~~~~~
| get_data_type

@jacobkahn
Copy link
Member

@tlyong3 — this continues to be a work in progress. We're awaiting some more correctness checks on our end and ensuring oneDNN 3.0 works on all of our build environments; pending that, I'll move everything over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants