Always dup argument to preserve original encoding for force_encoding #537

aeroastro · 2023-08-14T12:58:38Z

This fixes #529.

In order to avoid changing original encoding,
this patch always dups argument for ASCII-8BIT encoding.

I have also added a test test_argument_encoding_for_binary.
The structure is following test_argument_encoding.

Considering the following facts, IMHO, I believe this patch meets the original intention of this gem.

JSON::Pure::Parser.new(str) does not change the encoding of original argument for ASCII-8BIT
There already exists a test to guarantee that the encoding of argument is not changed for non ASCII-8BIT encodings.

Dani-beef · 2023-10-01T00:31:59Z

require 'json'

str = '{ "hoge": "fuga" }'.force_encoding('ASCII-8BIT')

puts 'JSON'
puts "Before: #{str.encoding}"
puts JSON.parse(str)
puts "After: #{str.encoding}"

puts

str = '{ "hoge": "fuga" }'.force_encoding('ASCII-8BIT')

puts 'JSON::Ext::Parser'
puts "Before: #{str.encoding}"
puts JSON::Ext::Parser.new(str).parse
puts "After: #{str.encoding}"

Always dup argument to preserve original encoding for force_encoding

9db2b4e

Provide feedback