Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an attendance page #66

Merged
merged 17 commits into from Mar 8, 2024
Merged

Added an attendance page #66

merged 17 commits into from Mar 8, 2024

Conversation

suuunly
Copy link
Contributor

@suuunly suuunly commented Feb 29, 2024

No description provided.

@suuunly suuunly linked an issue Feb 29, 2024 that may be closed by this pull request
Only show users that are related to specific conferences and have tickets #38
Closed
@vercel Vercel
Copy link

vercel bot commented Feb 29, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
luttaka ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 2:51pm
open-source-conference-app ❌ Failed (Inspect) Mar 7, 2024 2:51pm

@suuunly
Copy link
Contributor Author

suuunly commented Mar 1, 2024

I am hopping over on a different project. So someone else is welcome to take over this PR.

What requires testing before it can be set to ready for review is the following:

  • verify that the attendance-my-conference.procedure.ts method works as expected.
    • this will require you to make sure that when you buy a ticket, that it is attached to a given conference. (this may additional development from a separate PR)
    • verify that when you select between conferences under the attendances page, that it shows the appropriate attendees

@suuunly
Copy link
Contributor Author

suuunly commented Mar 1, 2024

@Fjandin, would you like to update the ticketing system to connect to specifically created conferences? 😄

@suuunly suuunly marked this pull request as ready for review March 7, 2024 14:37
@suuunly suuunly requested a review from Fjandin March 7, 2024 14:54
Fjandin
Fjandin approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@Fjandin Fjandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@suuunly suuunly merged commit b75cb0d into main Mar 8, 2024
2 checks passed
@suuunly suuunly deleted the 38-only-show-users-that-are-related-to-specific-conferences-and-have-tickets branch March 8, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fjandin Fjandin Fjandin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only show users that are related to specific conferences and have tickets
2 participants
@suuunly @Fjandin