Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conference hotfix #76

Merged
merged 5 commits into from Mar 4, 2024
Merged

Conference hotfix #76

merged 5 commits into from Mar 4, 2024

Conversation

Fjandin
Copy link
Contributor

@Fjandin Fjandin commented Mar 4, 2024 •
edited

  • Fix missing stripe code in conference transformer
  • rename files

@vercel Vercel
Copy link

vercel bot commented Mar 4, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
luttaka ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 1:20pm

@Fjandin Fjandin requested a review from suuunly March 4, 2024 13:20
suuunly
suuunly reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@suuunly suuunly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that when I tried to yarn install, I had to upgrade my node version. Maybe this should be mentioned in the readme.
I am currently on 20.1.0. I switched to 20.11.0, and then it worked :)

The package in question, is sharp

@Fjandin
Copy link
Contributor Author

Fjandin commented Mar 4, 2024

I noticed that when I tried to yarn install, I had to upgrade my node version. Maybe this should be mentioned in the readme. I am currently on 20.1.0. I switched to 20.11.0, and then it worked :)

The package in question, is sharp

hm... I haven't added any sharp

@Fjandin Fjandin requested a review from suuunly March 4, 2024 13:25
suuunly
suuunly approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@suuunly suuunly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! A little confused by the Admin text in the Conference page. but given that it is all WIP, and a final design is not set yet. I think it is perfectly fine :D

@suuunly
Copy link
Contributor

suuunly commented Mar 4, 2024

I noticed that when I tried to yarn install, I had to upgrade my node version. Maybe this should be mentioned in the readme. I am currently on 20.1.0. I switched to 20.11.0, and then it worked :)
The package in question, is sharp

hm... I haven't added any sharp

no worries. I will create an issue for that :)

@suuunly
Copy link
Contributor

suuunly commented Mar 4, 2024

issue #77 created 😄

@Fjandin Fjandin merged commit bc0d9b0 into main Mar 4, 2024
2 checks passed
@Fjandin Fjandin deleted the conference-hotfix branch March 4, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suuunly suuunly suuunly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Fjandin @suuunly