Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log/console_adapter: support 'console' gem v1.25 #4492

Merged
merged 1 commit into from
May 17, 2024

Conversation

daipom
Copy link
Contributor

@daipom daipom commented May 13, 2024

Which issue(s) this PR fixes:

What this PR does / why we need it:
Console::Terminal::Logger class path has changed in console gem v1.25:

socketry/console@v1.24.0...v1.25.0#diff-6e7355da8b6a8f794e74e462aebbe4b23f7752dab2a29967d17707eabb71ce12

This causes LoadError for ConsoleAdapter.
It means that LoadError occurs for plugin_helper/http_server/server, and Fluentd replaces the helper by plugin_helper/http_server/compat/server.
It also causes the CI failures.

This PR fixes these problems.
Please see #4487 for details.

Note: We can't stop considering the older versions because v1.25
requires Ruby v3.1 or older.

Note: There is another issue about console gem v1.25:

Docs Changes:
Not needed because this is a bug fix.

Release Note:
HttpServer helper: Fixed a problem that some Fluentd logs were not being output.

@daipom
Copy link
Contributor Author

daipom commented May 13, 2024

I forgot to consider Ruby versions before 3.1.
I will add it.

`Console::Terminal::Logger` class path has changed in `console`
gem v1.25:

socketry/console@v1.24.0...v1.25.0#diff-6e7355da8b6a8f794e74e462aebbe4b23f7752dab2a29967d17707eabb71ce12

Note: We can't stop considering the older versions because v1.25
requires Ruby v3.1 or older. 

For the v1.25, there is another issue about a warning(fluent#4488):

    Fiber#storage has borked keys and is being monkey-patched.

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@daipom daipom force-pushed the console-adapter-support-console-v1.25 branch from 9e9c5f2 to daa6c76 Compare May 13, 2024 07:11
@daipom
Copy link
Contributor Author

daipom commented May 13, 2024

About the failures on Windows, I have made an issue:

It doesn't seem to have anything to do with this fix.

@daipom
Copy link
Contributor Author

daipom commented May 17, 2024

@ashie @kenhys Could you please see this?
We have another option to keep console v1.24.
I'd like to hear your opinion.

@daipom
Copy link
Contributor Author

daipom commented May 17, 2024

About the failures on Windows, I have made an issue:

It doesn't seem to have anything to do with this fix.

Resolved.

@ashie ashie merged commit b15cda4 into fluent:master May 17, 2024
16 checks passed
@daipom daipom deleted the console-adapter-support-console-v1.25 branch May 17, 2024 08:33
@daipom
Copy link
Contributor Author

daipom commented May 17, 2024

Thanks!

@daipom daipom added this to the v1.16.6 milestone May 22, 2024
@daipom
Copy link
Contributor Author

daipom commented May 22, 2024

We need to backport this to v1.16

@daipom daipom removed this from the v1.16.6 milestone May 22, 2024
@daipom
Copy link
Contributor Author

daipom commented May 22, 2024

We need to backport this to v1.16

Sorry, we should not.
On v1.16, we should stay using console v1.24, given the purpose of the stable branch.

@daipom daipom added this to the v1.17.1 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'console' gem v1.25 causes LoadError
2 participants