-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log/console_adapter: support 'console' gem v1.25 #4492
log/console_adapter: support 'console' gem v1.25 #4492
Conversation
I forgot to consider Ruby versions before 3.1. |
`Console::Terminal::Logger` class path has changed in `console` gem v1.25: socketry/console@v1.24.0...v1.25.0#diff-6e7355da8b6a8f794e74e462aebbe4b23f7752dab2a29967d17707eabb71ce12 Note: We can't stop considering the older versions because v1.25 requires Ruby v3.1 or older. For the v1.25, there is another issue about a warning(fluent#4488): Fiber#storage has borked keys and is being monkey-patched. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
9e9c5f2
to
daa6c76
Compare
About the failures on Windows, I have made an issue: It doesn't seem to have anything to do with this fix. |
Resolved. |
Thanks! |
We need to backport this to v1.16 |
Sorry, we should not. |
Which issue(s) this PR fixes:
What this PR does / why we need it:
Console::Terminal::Logger
class path has changed inconsole
gem v1.25:socketry/console@v1.24.0...v1.25.0#diff-6e7355da8b6a8f794e74e462aebbe4b23f7752dab2a29967d17707eabb71ce12
This causes
LoadError
forConsoleAdapter
.It means that
LoadError
occurs forplugin_helper/http_server/server
, and Fluentd replaces the helper byplugin_helper/http_server/compat/server
.It also causes the CI failures.
This PR fixes these problems.
Please see #4487 for details.
Note: We can't stop considering the older versions because v1.25
requires Ruby v3.1 or older.
Note: There is another issue about
console
gem v1.25:Docs Changes:
Not needed because this is a bug fix.
Release Note:
HttpServer helper: Fixed a problem that some Fluentd logs were not being output.