New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Qodana issues #2450
Comments
For every complaint Qodana has, please think about whether the change is justified. |
A lot of issues (162) are due to `Member can be made private (non-private accessibility), e.g. According to JetBrains
Would it make sense, to explicitely annotate all these public methods with the PublicAPI attribute, or should we rather disable the rule |
There is an open change request from Dennis, to exclude TFMs: https://youtrack.jetbrains.com/issue/QD-7401/Allow-excluding-or-including-certain-.NET-framework-targets FYI: this happens, because we do not test .netstandard2.0+ anymore (since we dropped direct support for .netcore2.x and 3.x |
Please postpone the work on this issue. It's consuming too much of our time to work on the things we need to finish for v7. |
Background and motivation
The Qodana baseline scan has currently 1,049 problems
Probably not all problems can be fixed, but the easy fixes should be applied, to reduce the number of issues and reduce the allowed threshold in the build pipeline.
Alternative Concerns
No response
Are you willing help with a pull-request?
Yes, please assign this issue to me.
The text was updated successfully, but these errors were encountered: