-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runkit embeds fail with error: Unable to load embed. Syntax error found in Preamble. See console for error. #9773
Comments
Thanks for the issue! We'll take your request into consideration and follow up if we decide to tackle this issue. To our amazing contributors: issues labeled To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss and we will follow up within 3 business days. For full info on how to contribute, please check out our contributors guide. |
Also seeing this in https://dev.to/glebec/monadic-parser-combinators-an-interactive-js-tutorial-pt-1-3jbo. I think the problem is a regression bug in preamble support, but I haven't done more than a minute's worth of debugging yet or identified what would have caused such a regression (and when). See #662 and #696 for info on how/when preamble support was added. Example of a snippet without preamble: {% runkit %}
foo()
{% endrunkit %} With preamble (possibly what is now breaking): {% runkit
let bar = 5
%}
foo(bar)
{% endrunkit %} |
Thanks for digging into this @glebec! Would this be something you're interested in solving yourself or is this issue still up for grabs? |
@citizen428 it is certainly up for grabs – I just wanted to provide a little context, but I don't know when I'll have the time to dig deeper. |
No worries at all @glebec, thanks for clarifying. |
@rhymes Hi. I'd like to give this a shot if that's okay. |
Hi @akashdotsrivastava, please go ahead! thanks! |
@joelnet Can you find some time to drop a couple of exact runkit tags with preamble you have included in the article https://dev.to/joelnet/creating-a-linked-list-using-only-function-combinators-5hhk, the ones which are giving the error Asking because I have tried the example above
and it seems to render fine. An exact example would help. |
I created a gist here so you can copy the raw https://gist.github.com/joelnet/55aede139467d110e276d0ab71e26776 |
@joelnet Thank you 👍 |
@rhymes Thank you for assigning this to me. I added a PR for the fix. |
I still had this error on https://dev.to/glebec/when-nesting-promises-is-correct-h8f. It turned out that opening the article in edit mode and saving changes fixed it, presumably because the article was re-run through the fixed text processing logic. |
Describe the bug
Runkit is reporting an error:
Unable to load embed. Syntax error found in Preamble. See console for error.
The first 2 Runkit embeds seem to work fine. Others after are failing.
To Reproduce
Unable to load embed. Syntax error found in Preamble. See console for error.
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: