Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@formatjs/icu-messageformat-parser): remove orphaned type #4418

Merged
merged 1 commit into from May 18, 2024

Conversation

Renegade334
Copy link
Contributor

Resolves #4413.

There doesn't appear to be any dissent raised to removing this, and it's definitely not used internally, nor would there be any reason to.

@longlho longlho changed the title Remove orphaned type from icu-messageformat-parser fix(@formatjs/icu-messageformat-parser): remove orphaned type from icu-messageformat-parser May 15, 2024
@longlho longlho added this pull request to the merge queue May 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@Renegade334 Renegade334 changed the title fix(@formatjs/icu-messageformat-parser): remove orphaned type from icu-messageformat-parser fix(@formatjs/icu-messageformat-parser): remove orphaned type May 15, 2024
@Renegade334
Copy link
Contributor Author

Looks like one of the test suites timed out.

@longlho longlho added this pull request to the merge queue May 18, 2024
Merged via the queue into formatjs:main with commit d072aa5 May 18, 2024
1 check passed
@longlho
Copy link
Member

longlho commented May 18, 2024

Thanks a lot for your contributions!

longlho pushed a commit that referenced this pull request May 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 18, 2024
…aad (#4420)

* Remove orphaned type from icu-messageformat-parser (#4418)

* chore(deps): update io_buildbuddy_buildbuddy_toolchain digest to dfb7aad

---------

Co-authored-by: René <Renegade334@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request May 18, 2024
* Remove orphaned type from icu-messageformat-parser (#4418)

* chore(deps): update dependency @types/node to v18.19.33

---------

Co-authored-by: René <Renegade334@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request May 18, 2024
* Remove orphaned type from icu-messageformat-parser (#4418)

* chore(deps): update dependency @napi-rs/cli to v2.18.3

---------

Co-authored-by: René <Renegade334@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request May 18, 2024
…10.3 (#4421)

* Remove orphaned type from icu-messageformat-parser (#4418)

* fix(deps): update dependency @types/babel__helper-plugin-utils to v7.10.3

---------

Co-authored-by: René <Renegade334@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seemingly orphaned type IntlLocaleLike in icu-messageformat-parser
2 participants