Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for absolute paths #312

Open
1 task done
tabesin opened this issue Oct 24, 2018 · 2 comments
Open
1 task done

Check for absolute paths #312

tabesin opened this issue Oct 24, 2018 · 2 comments

Comments

@tabesin
Copy link
Member

tabesin commented Oct 24, 2018

I'm submitting a ... (check one with "x")

  • feature request

Actual Behaviour
The zip files contents are to be put on the desktop of Meilix. However we do not check if they contain files with absolute paths which should not be the case.

Expected Behaviour
Some reasonable, or even heuristic checking if the zips when unpacked in the Desktop folder would stay in the users home dir, in other words only contain relative paths. As we may unpack the zips with root privilege that may become also a security risk.

Example
A file /home/egon/desktop/presentations/mypresentation.ppt should not be packed but a contained /presentations/mypresentation.ppt would be useful because when the home directory is e.g. /home/peter the files won't end up there.

Mind that we may support multiple zip formats here like .tar.gz and .zip.

@tabesin tabesin added the GCI Google Code-in task label Oct 24, 2018
@sarnava1
Copy link
Member

Any GCI participants doing this?

@sarnava1
Copy link
Member

@Stealthinator16 you can have a try here.

@mariobehling mariobehling removed GCI Google Code-in task labels Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants