Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quoting issues using the formatter #306

Open
Morriz opened this issue Dec 20, 2022 · 0 comments
Open

quoting issues using the formatter #306

Morriz opened this issue Dec 20, 2022 · 0 comments
Labels
upstream the upstream problem

Comments

@Morriz
Copy link

Morriz commented Dec 20, 2022

We see quoting issues after activating this extension

Variables that were quoted before, are quoted again, leading to incorrect commands. Example:

mount="-v /tmp:/tmp"
cmd="bash"
conditional_flag=''
docker run $mount $conditional_flag busybox bash -c $cmd

becomes

docker run "$mount" "$conditional_flag" busybox bash -c "$cmd"

which translates to

docker run '-v /tmp:/tmp' '' busybox bash -c 'echo ok'

which makes the comand invalid because of the empty quotes

@foxundermoon foxundermoon added the upstream the upstream problem label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream the upstream problem
Projects
None yet
Development

No branches or pull requests

2 participants