Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image being centered to the height of page height and not viewport height #163

Open
mckeever02 opened this issue Nov 10, 2020 · 1 comment
Open

Image being centered to the height of page height and not viewport height #163

mckeever02 opened this issue Nov 10, 2020 · 1 comment
Labels
Status: Needs Reproduction

Comments

@mckeever02
Copy link

I noticed something that I think is related to the fix implemented for Issue #75

In this issue the code was changed from:

width: window.innerWidth,
height: window.innerHeight,

to:

width: document.documentElement.clientWidth,
 height: document.documentElement.clientHeight,

However, this leads to the image (for me) being displayed off of the screen as it gets positioned to the height of the document and not the screen. When I change it back to window.innerHeight it works correctly.
@mckeever02 mckeever02 changed the title Image being centered to height of page height and not window height Image being centered to height of page height and not viewport height Nov 10, 2020
@mckeever02 mckeever02 changed the title Image being centered to height of page height and not viewport height Image being centered to the height of page height and not viewport height Nov 10, 2020
@francoischalifour
Copy link
Owner

Can you share screenshots of how this works better in your case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Reproduction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mckeever02 @francoischalifour