Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with <blockquote> #377

Closed
yzhiJun opened this issue Oct 30, 2014 · 8 comments
Closed

Bug with <blockquote> #377

yzhiJun opened this issue Oct 30, 2014 · 8 comments
Labels

Comments

@yzhiJun
Copy link

yzhiJun commented Oct 30, 2014

Repro Steps:

  • type some text and enter new line
  • select all of them and hit blockquote button
    image
    image

I got something like that in Mac chrome 38.0.2125.104

@SimeonC SimeonC added the bug label Oct 30, 2014
@SimeonC
Copy link
Collaborator

SimeonC commented Oct 31, 2014

Fixed as of v1.3.0-pre11.

@yzhiJun
Copy link
Author

yzhiJun commented Oct 31, 2014

Hi @SimeonC , It raise another bug in v1.3.0-pre11
image
If I enter new line between text,It become like that:
image

@SimeonC SimeonC reopened this Oct 31, 2014
@SimeonC
Copy link
Collaborator

SimeonC commented Oct 31, 2014

Ugh, so I see. Thanks for letting me know. Probably can't fix this till next week now.

@yzhiJun
Copy link
Author

yzhiJun commented Oct 31, 2014

Thinks for great project
btw,another question, currently if I type something like:
image
when i hit enter it become:
image
it would be great to create new <p> like:
image

@SimeonC
Copy link
Collaborator

SimeonC commented Oct 31, 2014

Yes, I agree with that functionality, I'll see what I can do when I fix the other one.

SimeonC pushed a commit that referenced this issue Nov 4, 2014
@SimeonC SimeonC closed this as completed in 63480a6 Nov 4, 2014
@SimeonC
Copy link
Collaborator

SimeonC commented Nov 4, 2014

Should be fixed now in pre12

@yzhiJun
Copy link
Author

yzhiJun commented Nov 4, 2014

Hi,@SimeonC , another bug I find,the blockquote,ul,ol will add double new line between text
image
image

@yzhiJun
Copy link
Author

yzhiJun commented Nov 6, 2014

Hello @SimeonC , I have deep into your code and find where cause the bug
https://github.com/fraywing/textAngular/blob/master/src/textAngular.js#L867
and
https://github.com/fraywing/textAngular/blob/master/src/textAngular.js#L945
It return all child to the _nodes.... like (<p></br></p> it become [p,br]) which cause the bug
I change _nodes = taSelection.getOnlySelectedElements() to _nodes = $target.children() and fixed

Btw, I have't test it in all case , just let you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants