Paste content

[snekbaev]

Hi,

didn't test in other browsers, but IE11: if I copy content/some part of it from the editor and try to paste back it crashes with:

SCRIPT5022: HierarchyRequestError
File: angular-textAngular.js, Line: 25, Column: 11246

P.S.: using 1.3.0-pre12

[SimeonC]

Thanks, I'll have a look into it when I can.

[SimeonC]

OK, this one I can't replicate at all. Can you replicate it in a plunkr or similar please?

[snekbaev]

Can't quickly reproduce in plunkr, however if I modify the insertHtml function:

for (var _n in nodes) lastNode = frag.appendChild(nodes[_n]);

to

for (var _n = 0; _n < nodes.length; _n++) lastNode = frag.appendChild(nodes[_n]);

error is gone, this reminds me what I ran into another project: witoldsz/angular-http-auth#48

also that link mentions that regular for is faster :) maybe if you could change all foreach to for so that we could fix other similar issues and increase the performance? :)

[snekbaev]

another thing related to pasting: if I keep on pressing Ctrl+V content is inconsistent. It starts pasting then at some point trims, so if you had 50 characters and continue pasting all of a sudden you may end up having 10 etc. And this keeps repeating. This dirty quick fix addresses it:

var waitforpastedata = function (savedcontent, _savedSelection, cb) {
    if (element[0].childNodes && element[0].childNodes.length > 0) {
        cb(savedcontent, _savedSelection);
    } else {
        that = {
            s: savedcontent,
            _: _savedSelection,
            cb: cb
        };
        that.callself = function () {
            waitforpastedata(that.s, that._, that.cb);
        };
        setTimeout(that.callself, 20);
    }
};

becomes

var waitforpastedata = function (savedcontent, _savedSelection, cb) {
    var that = {
        s: savedcontent,
        _: _savedSelection,
        cb: cb
    };
    that.callself = function () {
        cb(savedcontent, _savedSelection);
    };

    setTimeout(that.callself, 20);
};

[snekbaev]

if you open this plunkr - http://plnkr.co/edit/9VK84LnXR5h9YnQvq00V?p=preview in Chrome and IE11, then select text from any textangular field in IE and do paste into any textangular field in Chrome, then that field in Chrome with get extra markup, basically you will end up inserting a textangular editor into textangular editor. Other side effects I've encountered include additional markup or even script tag content

[SimeonC]

Thanks for the details, I'll look into it when I can.

[SimeonC]

Just stuck on the multi-paste issue currently, not sure about the quick and dirty fix.

Biggest problem I'm finding with this is that the "Solution" is a hack from here: http://stackoverflow.com/questions/2176861/javascript-get-clipboard-data-on-paste-event-cross-browser/6804718#6804718

My concerns so far are:

• Wouldn't reducing the timeout be better, say to 2ms or something like that?
• How would this function if we pasted say 200 lines of text or something else stupidly large that would take longer than 20ms to render into the page.

[snekbaev]

Well, can't really say much here, never tried to handle the paste data in the browser. Wild guess: maybe it is possible to disable any pasting while current paste operation is in progress?

[SimeonC]

Thanks, Good suggestion, I'll see if I can do that.

[SimeonC]

Helps if I push the fix up... Waiting on one more issue to come back and I'll push a pre-release.

[snekbaev]

It is ok, I can wait for the new -pre.
Thank you!

[SimeonC]

Ok, pre-release 18 is out and should be fixed now.