Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle html does not show all available html #584

Closed
kpomka opened this issue Mar 19, 2015 · 5 comments
Closed

Toggle html does not show all available html #584

kpomka opened this issue Mar 19, 2015 · 5 comments

Comments

@kpomka
Copy link

kpomka commented Mar 19, 2015

#566 has been fixed partially. Test-case:

it('handles no tags (should wrap all content)', function(){
    $rootScope.html = '<b>Test</b> Line 1';
    $rootScope.$digest();
    expect(element.val()).toBe('<p><b>Test</b> Line 1</p>');
});
@SimeonC
Copy link
Collaborator

SimeonC commented Mar 19, 2015

That's the correct functionality. From memory the reason is that the contenteditable does some really, really weird stuff/throws errors if you don't have some tag wrapping the content.

@kpomka
Copy link
Author

kpomka commented Mar 20, 2015

What i mean, in example provided when you toggle to html mode you will see only <b>Test</b> there. It will not show you the rest Line 1

@kpomka
Copy link
Author

kpomka commented Apr 1, 2015

Any updates on this issue? It should be minor, just wrap content with default wrapper.

@SimeonC SimeonC closed this as completed in 0cd98dd Apr 2, 2015
@SimeonC
Copy link
Collaborator

SimeonC commented Apr 2, 2015

Thanks for the test, It should be fixed in Master now and will be in next release.

@kpomka
Copy link
Author

kpomka commented Apr 2, 2015

Great job, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants