Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equality comparison puts parens in labels #25

Open
chick opened this issue Sep 30, 2019 · 1 comment
Open

equality comparison puts parens in labels #25

chick opened this issue Sep 30, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@chick
Copy link
Contributor

chick commented Sep 30, 2019

Certain equality comparisons can
created broken .dot files.

circuit HasPrintfProblem :
  module HasPrintfProblem :
    input clock : Clock
    input reset : UInt<1>
    output io : {flip in : UInt<10>, out : UInt<10>}

    wire y : UInt<10> @[PrintfTreadleVsVerilatorTest.scala 62:15]
    reg regY : UInt<10>, clock @[PrintfTreadleVsVerilatorTest.scala 65:17]
    reg regRegY : UInt<10>, clock @[PrintfTreadleVsVerilatorTest.scala 66:20]
    regY <= y @[PrintfTreadleVsVerilatorTest.scala 68:8]
    regRegY <= regY @[PrintfTreadleVsVerilatorTest.scala 69:11]
    y <= io.in @[PrintfTreadleVsVerilatorTest.scala 70:5]
    node _T = eq(regRegY, UInt<9>("h01e0")) @[PrintfTreadleVsVerilatorTest.scala 72:16]
    when _T : @[PrintfTreadleVsVerilatorTest.scala 72:27]
      node _T_1 = eq(regRegY, UInt<1>("h00")) @[PrintfTreadleVsVerilatorTest.scala 73:93]
      node _T_2 = eq(regRegY, UInt<9>("h01e0")) @[PrintfTreadleVsVerilatorTest.scala 73:110]
      node _T_3 = bits(reset, 0, 0) @[PrintfTreadleVsVerilatorTest.scala 73:11]
      node _T_4 = eq(_T_3, UInt<1>("h00")) @[PrintfTreadleVsVerilatorTest.scala 73:11]
      when _T_4 : @[PrintfTreadleVsVerilatorTest.scala 73:11]
        printf(clock, UInt<1>(1), "PRINTF y=%d ry=%d rry=%d isZero=%x regRegY=480=%x\n", y, regY, regRegY, _T_1, _T_2) @[PrintfTreadleVsVerilatorTest.scala 73:11]
        skip @[PrintfTreadleVsVerilatorTest.scala 73:11]
      skip @[PrintfTreadleVsVerilatorTest.scala 72:27]
    io.out <= regRegY @[PrintfTreadleVsVerilatorTest.scala 76:10]

@chick chick added the bug Something isn't working label Sep 30, 2019
@chick chick self-assigned this Sep 30, 2019
@chick
Copy link
Contributor Author

chick commented Sep 30, 2019

This should be fixed by PR #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant