Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge __pycache__ from packages #1907

Closed
legoktm opened this issue Mar 13, 2024 · 0 comments · Fixed by #1909
Closed

Purge __pycache__ from packages #1907

legoktm opened this issue Mar 13, 2024 · 0 comments · Fixed by #1909
Assignees

Comments

@legoktm
Copy link
Member

legoktm commented Mar 13, 2024

Description

We had a bit of a mixup freedomofpress/securedrop-apt-test#218 at where people built in non-pristine checkouts, causing __pycache__ folders to get pulled in the packages. We should make sure these are never included, regardless if they exist on disk.

@legoktm legoktm self-assigned this Mar 13, 2024
legoktm added a commit that referenced this issue Mar 13, 2024
We already delete the individual .pyc files because they're not
reproducible, but leave behind empty `__pycache__` folders. This can be
annoying if people are doing builds out of a development checkout that
has these folders that won't be present on a pristine build.

So remove the empty folders right after deleting the .pyc files.

Fixes #1907.
legoktm added a commit that referenced this issue Mar 14, 2024
We already delete the individual .pyc files because they're not
reproducible, but leave behind empty `__pycache__` folders. This can be
annoying if people are doing builds out of a development checkout that
has these folders that won't be present on a pristine build.

So remove the empty folders right after deleting the .pyc files.

Fixes #1907.

(cherry picked from commit 06ae37e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant