[android] Configuration Settings refactor

[gubatron]

Currently adding a new configuration setting is very tedious, it should be as simple as creating an object, similar to the way it works on desktop, in a single place, something like:

public static final ConfigurationSetting GUI_TOS_ACCEPTED = 
new ConfigurationSetting(
    Boolean.class, // class of the value
    "frostwire.prefs.gui.tos_accepted", // key
    false); // default value

public static final ConfigurationSetting GUI_INTERSTITIAL_ON_EXIT_THRESHOLD =
new ConfigurationSetting(
    Float.class,
    "frostwire.prefs.gui.interstitial_on_exit_threshold",
    0.35f);

...

// Then you use those like

ConfigurationSetting.GUI_TOS_ACCEPTED.value(); // gets the value
ConfigurationSetting.GUI_TOS_ACCEPTED.set(true); // updates the setting value
ConfigurationSetting.GUI_TOS_ACCEPTED.reset(); // resets to default value

and the whole thing gets taken care of, with backwards compatibility in one spot.

CC: @votaguz in case you want to do something different this weekend (and you have the time), this would be a useful refactor and a good study case to truly learn Java Generics.

To work on this ticket read:
Constants.java
ConfigurationManager.java
ConfigurationDefaults.java

[gubatron]

I think I'll do this one in Kotlin

[votaguz]

@gubatron are you still thinking on doing this using Kotlin or you want to stick with Java ?

[aldenml]

hi @votaguz, kotlin was removed because time passed and no real need was clear. Less code in the final apk