Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common/desktop] Thread/Threadpool consolidation #842

Open
gubatron opened this issue Jun 1, 2019 · 2 comments
Open

[common/desktop] Thread/Threadpool consolidation #842

gubatron opened this issue Jun 1, 2019 · 2 comments

Comments

@gubatron
Copy link
Collaborator

gubatron commented Jun 1, 2019

Open an experimental branch on which all ThreadPools, ExecutorService instances, ThreadExecutor, ThreadPoolExecutor are all managed by a single entity in charge of 2 or 3 threadpools, and curb the creation of threads.

We've already reduced thread stack with -Xss, 256k for macos, 196k for windows, Linux tests still pending.

The goal is to reduce thread usage to a minimum necessary and memory consumption for better performance.

@gubatron
Copy link
Collaborator Author

Some progress:

SearchManager 08effd5

HttpDownload 883d4ca

@gubatron
Copy link
Collaborator Author

gubatron commented Jan 14, 2020

2.1.9 builds address a lot of these issues for Android, but there's still over 100 threads out there

@gubatron gubatron reopened this Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant