Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do you think we should port HashMultiMap to #fsharpx? #166

Closed
jackfoxy opened this issue Nov 29, 2012 · 3 comments
Closed

do you think we should port HashMultiMap to #fsharpx? #166

jackfoxy opened this issue Nov 29, 2012 · 3 comments

Comments

@jackfoxy
Copy link
Contributor

@forki asks "@foxyjackfox do you think we should port HashMultiMap to #fsharpx?"

Ultimately I think it would benefit the community to have a single open source project for all data structures and collections not in the Microsoft.FSharp namespace.

However, I'm not convinced there is enough value in this proposition to undertake implementing all the https://github.com/fsharp/powerpack collections and tagged collections in FSharpx. This is complicated by the PowerPack types all being in the Microsoft.FSharp.Collections and Microsoft.FSharp.Collections.Tagged namespaces (but not being in FSharp.Core.Dll), and what few examples of HashMultiMap usage are available all use Microsoft.FSharp.Collections.HashIdentity module for the comparer, which is not only in the MS namespace, but actually in FSharp.Core.Dll. In my opinion if PowerPack is to be deprecated for collections, then the collections should be subsumed by FSharp.Core.Dll, which is probably not possible.

@ghost
Copy link

ghost commented Nov 29, 2012

HashMultiMap really exists to support the OCaml Hashtbl.* compatibility module. In the long run I think it logically belongs in FSharpx.Compatibility.OCaml DLL (where FSharpx should also have an FSharpx.Compatibility.Python, FSharpx.Compatibility.Matlab etc.)

@jackfoxy
Copy link
Contributor Author

Included this topic in a larger discussion of FSharpx Data Structures, looking for community feedback http://jackfoxy.com/fsharpx-data-structures-discussion

@ghost
Copy link

ghost commented Jun 24, 2013

I'll close this for now. I don't think the conclusion of the community discussion was to include this in FSharpx.

@ghost ghost closed this as completed Jun 24, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant