Ensure absolute path is used for library extraction and loading #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[`System#load`][1] requires an absolute path. If the extraction
directory (`library.${name}.path` or `java.io.tmpdir`) is relative, the
extraction will succeed, but the `System#load` call will fail, resulting
in the library not being loaded. This commit rectifies that by
obtaining the absolute path to the directory before extracting.
[1]: http://docs.oracle.com/javase/7/docs/api/java/lang/System.html#load(java.lang.String)
chirino
added a commit
that referenced
this pull request
Oct 7, 2014
Ensure absolute path is used for library extraction and loading
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System#loadrequires an absolute path. If the extractiondirectory (
library.${name}.pathorjava.io.tmpdir) is relative, theextraction will succeed, but the
System#loadcall will fail, resultingin the library not being loaded. This commit rectifies that by
obtaining the absolute path to the directory before extracting. Now,
the extracted file will be referred to by its absolute path, which
should make the
System#loadcall succeed.