Use Files.setPosixFilePermissions for chmod when possible #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use Java 7 Files.setPosixFilePermissions to avoid forking the JVM for executing chmod 755 when possible - fallback to regular Runtime#exec()
slaunay
force-pushed
the
use-java7-chmod-with-unix-chmod-fallback
branch
from
b755602
to
61ac652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using lmdbjni for joining data inside MapReduce jobs where the maps are generally short lived.
Those processes can be configured with both
-Xmsand-Xmxto ensure enough memory is available but loading the library slows down the process at startup as it needs to fork the whole process in order to executechmodin GNU/Linux.The following code change uses Java 7 facilities for setting permissions and is backward compatible with Java 5/6 thanks to reflection:
Files.setPosixFilePermissionsto avoid forking the JVM for executingchmod 755when possible (Java 7+)Runtime#exec()