Add the example project from the README to quickly test out JAnsi #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey. Could you update this or to resolve the conflicts? |
|
@chirino Done. |
| @@ -129,7 +129,7 @@ public void close() throws IOException { | |||
| }; | |||
| } | |||
|
|
|||
| private static boolean isCygwin() { | |||
| private static boolean isXterm() { | |||
There was a problem hiding this comment.
this one is not about example
but it seems a good change: yes, given the implementation, this method should be renamed!
+1
There was a problem hiding this comment.
Yes, it's unrelated to the global topic of the PR, but then again that's why it's a separate commit. As it's such a small change I did not bother to explicitly mention it in the PR's description.
Strictly speaking this method does not check for Cygwin (as it e.g. does not check to be on Windows) but only for XTerm (which in conjunction with being on Windows is a sign of running under Cygwin). Simplify the code a bit to get rid of the explicit null check long the way.
This provides a minimal test executable for quickly trying out JAnsi. Run it like $ mvn --projects example exec:java
|
Thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.