Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why rename the .jar? #390

Open
ryanhamilton opened this issue Jan 23, 2024 · 2 comments
Open

Why rename the .jar? #390

ryanhamilton opened this issue Jan 23, 2024 · 2 comments
Labels
feedback Waiting for feedback

Comments

@ryanhamilton
Copy link

Hi, Your tool is working great. Thanks.

One question, for linux why do you rename the .jar?

I'm asking as:

  1. Keeping it .jar in theory makes it still easily runnable for a windows user that downloads the wrong package.
  2. Keeping it .jar, would make it clear to the linux user that it's a java file.

I don't see the benefit to changing the name?

I even tried setting runnableJar = file("app.jar.jar") but it removed both the .jars :)

@fvarrui
Copy link
Owner

fvarrui commented Feb 25, 2024

Hi @ryanhamilton!
Some files are renamed with the generic name "app.*" because some tools (like launch4j) don't support filenames with CHK characters ... maybe this not happens on Linux, but it was implemented as a generic behaviour

@fvarrui
Copy link
Owner

fvarrui commented Feb 25, 2024

Hi, Your tool is working great. Thanks.

You are welcome 😄

@fvarrui fvarrui added the feedback Waiting for feedback label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback Waiting for feedback
Projects
None yet
Development

No branches or pull requests

2 participants