New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins #52
Comments
Oh this looks like you've done some very nice work there, thank you! Looks ilke a lot of these changes would be very useful for this upstream project, so thank you for sharing :) I haven't thought in detail about how a plugin infrastructure could look like (that's different from a modular structure, which would at least allow to add additional services more easily. I agree Dropbox is currently at the core of this app). I am not opposed to it, but maybe enabling a good, structurally sound modular architecture is a better investment than enabling arbitrary plugin code that can hook into the compiled .app.? On the other hand, I can see how that wouldn't scale if people wanted to see 37 different upload services supported. |
@fwenzel I had a co-worker try to install my fork (3 of them, in fact) and they all couldn't launch the app. One tried to recompile and launch and was hitting this:
Is that something you're familiar with? Would love guidance so I can fix my build! Thanks. |
I actually run Python 2.7 from homebrew, perhaps that makes a difference? Otherwise the way I set it up is like the README says: Make a virtualenv, activate it, install dependencies and make a build. Are you able to create the app and launch it on your own computer but it doesn't work on your coworkers' machines? Or does it not work for you either? What output do you get from the build command? |
I also installed Python 2.7 via homebrew and my fork works for me, I was trying to tease out what the differences between our machines might be. I assumed that once you created the .app that it would bake in all the dependencies but I guess that might not be the case. My co-worker says he did install Python 2.7 via brew but thinks he needed to also do |
That's how it's supposed to be yes.
If so, then let me know and I have to update the readme! |
Just to clarify, everyone except me has problems running the .app container If you're willing, Id like to hear if it works for you or if the binary
|
Sure, zip it up and shoot me an email (or link) |
I forked upshot here: https://github.com/mikeknoop/upshot
For the most part, this was done to rip out the DropBox dependency and replace it with a custom uploading mechanism so I could handle the image saving server-side.
I also made a few other tweaks, added sound support, etc. But the biggest thing I thought upshot could use is a plugin architecture. DropBox was intertwined in many places (including hard to modify .nib files).
Have you considered what a plugin architecture might look like? You could use my branch as a reference for a "cleaner slate" that already has most DB stuff ripped out.
The text was updated successfully, but these errors were encountered: