Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When move a rect from the right side to the left and the rect goes below x0, the top and bottom lines are redrawn to the left of the screen. #3

Open
jpliew opened this issue Jul 21, 2014 · 4 comments

Comments

@jpliew
Copy link
Contributor

jpliew commented Jul 21, 2014

Hi,

I want to report a small bug in the microview API.

When I move a rect from the right side to the left and the rect goes below x0, the top and bottom lines are redrawn to the left of the screen.

You can see the bug in action here:
https://codebender.cc/sketch:40168

Best regards,
Maarten Cammaert

@marzsman
Copy link

Thx for submitting my issue.
Made a mistake in my comment. It should be, the lines are redrawn to the right side of the screen.

@jpliew
Copy link
Contributor Author

jpliew commented Jul 21, 2014

I think it is the parameters that is unsigned , so passing a negative number will cause the variable to wrap to positive number.

Sent from Yahoo!7 Mail on Android

@jpliew
Copy link
Contributor Author

jpliew commented Aug 4, 2014

I relooked at this issue again and I am not sure if we want to support drawing beyond the screen. Maybe let a few more backers to decide before making changes, as the changes requires changing all the uint8_t variables that we use, and we will then also need to decide how far should the library need to support beyond the screen to determine the variable int8 or int16 or int32.

@vliedel
Copy link

vliedel commented Mar 25, 2015

I'd leave it to the user to ensure not to pass boundaries, would only make the library slower. Make sure it's documented though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants