Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPRIS volume change isn't reflected on volume slider #817

Open
rdbende opened this issue Dec 6, 2023 · 1 comment
Open

MPRIS volume change isn't reflected on volume slider #817

rdbende opened this issue Dec 6, 2023 · 1 comment
Labels

Comments

@rdbende
Copy link
Collaborator

rdbende commented Dec 6, 2023

Bug/Feature description

When changing application volume through MPRIS, the current volume isn't updated on the volume slider, and opening and moving it manually makes the volume jump back to where the slider thinks it is.

System Information

  • Operating System: Fedora 39
  • Installation source: Flatpak build
  • Version of cozy: master branch
@rdbende
Copy link
Collaborator Author

rdbende commented Dec 9, 2023

Turns out, it is handled by the GStreamer player bin itself, not the MPRIS interface.

However, due to the many abstraction layers, it's quite hard to fix it, because we either have to use an ugly workaround with private properties (self._player._gst_player._player.connect("notify::volume", self._on_volume)), or have to propagate the notify::volume signal through gst_player.GstPlayer -> player.Player -> playback_control_view_model.PlaybackControlViewModel -> media_controller.MediaController.
My feeling is that there are too much abstraction layers in this stack, and should be refactored.

@geigi geigi added the bug label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants