Skip to content

Commit

Permalink
The latest version of splinter no longer supports phantomjs, use the …
Browse files Browse the repository at this point in the history
…default firefox driver instead.
  • Loading branch information
Coop56 committed Mar 20, 2019
1 parent a4974af commit 4b651df
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 17 deletions.
3 changes: 1 addition & 2 deletions geonode/tests/bdd/e2e/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,11 @@
@pytest.yield_fixture(scope='function', autouse=True)
def en_browser(browser, bdd_server):
"""Browser login page from live server."""
browser = Browser('phantomjs')
browser = Browser()
en_browser = browser
en_browser.visit(urljoin(bdd_server.url, '/account/login/'))
yield en_browser
try:
# kill the specific phantomjs child proc
en_browser.service.process.send_signal(signal.SIGTERM)
except BaseException:
pass
Expand Down
1 change: 0 additions & 1 deletion pytest.ini
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ python_classes = *Test
python_functions = test_*
pep8maxlinelength = 79
testpaths = geonode/tests/bdd/e2e/
addopts = --splinter-webdriver=phantomjs
1 change: 1 addition & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ flake8==3.7.7
pytest==4.3.1
pytest-bdd==3.1.0
splinter==0.10.0
pytest-splinter==2.0.1
pytest-django==3.4.8
setuptools==40.8.0
Twisted==18.9.0
14 changes: 0 additions & 14 deletions scripts/misc/bdd_setup.sh

This file was deleted.

0 comments on commit 4b651df

Please sign in to comment.