-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Alessio Fabiani
committed
Jul 12, 2019
1 parent
e8422e1
commit d771ddb
Showing
1 changed file
with
23 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <Include a few sentences describing the overall goals for this Pull Request> | ||
|
|
||
| ## Checklist | ||
|
|
||
| > Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them. | ||
| For all pull requests: | ||
|
|
||
| - [ ] Confirm you have read the [contribution guidelines](https://github.com/GeoNode/geonode/blob/master/CONTRIBUTING) | ||
| - [ ] You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation) | ||
| - [ ] Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones. | ||
|
|
||
| The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules): | ||
| - [ ] There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users) | ||
| - [ ] The issue connected to the PR must have Labels and Milestone assigned | ||
| - [ ] PR for bug fixes and small new features are presented as a single commit | ||
| - [ ] Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue" | ||
| - [ ] New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented | ||
| - [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR) | ||
| - [ ] This PR passes the QA checks: flake8 geonode | ||
| - [ ] Commits changing the **settings**, **UI**, **existing user workflows**, or adding **new functionality**, need to include documentation updates | ||
|
|
||
| **Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.** |