Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Panel] Email Dialog: Wrong translation key for title field #6402

Closed
SebastianEberlein-JUNO opened this issue Apr 18, 2024 · 0 comments
Closed

[Panel] Email Dialog: Wrong translation key for title field #6402

SebastianEberlein-JUNO opened this issue Apr 18, 2024 · 0 comments
Assignees
@afbora
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Milestone
4.2.1

Comments

@SebastianEberlein-JUNO
Copy link

Description

The email dialog shows "Link text" as label for the title field, because the translation key is link.text.
https://github.com/getkirby/kirby/blob/main/panel/src/components/Dialogs/EmailDialog.vue#L27

Expected behavior
The link dialog uses title as key, so the email dialog should use the same.
https://github.com/getkirby/kirby/blob/main/panel/src/components/Dialogs/LinkDialog.vue#L28

Screenshots
Screenshot

Your setup

Kirby Version
4.2.0

Your system
Chrome 124 on macOS 14.4
@afbora afbora added the type: bug 🐛 Is a bug; fixes a bug label Apr 23, 2024
@afbora afbora self-assigned this Apr 23, 2024
@afbora afbora added this to the 4.2.1 milestone Apr 23, 2024
afbora added a commit that referenced this issue Apr 23, 2024
@afbora
Fix email dialog title prop translation #6402
251d8cd
@afbora afbora mentioned this issue Apr 23, 2024
Merged
5 tasks
@afbora afbora added type: enhancement ✨ Suggests an enhancement; improves Kirby and removed type: bug 🐛 Is a bug; fixes a bug labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afbora afbora

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
4.2.1
Development

No branches or pull requests
3 participants
@bastianallgeier @afbora @SebastianEberlein-JUNO