Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimeException in io.sentry.graphql.SentryInstrumentation #3341

Open
kahest opened this issue Apr 10, 2024 · 1 comment
Open

RuntimeException in io.sentry.graphql.SentryInstrumentation #3341

kahest opened this issue Apr 10, 2024 · 1 comment

Comments

@kahest
Copy link
Member

kahest commented Apr 10, 2024

Description

RuntimeException in io.sentry.graphql.SentryInstrumentation in lambda$instrumentExecutionResult$0 at line 208

Affected packages and versions:

  • see Discover
  • note that versions before 7.0.0 might also be affected but SDK crash reporting is only supported from version 7.0.0+

Internal references:

@adinauer
Copy link
Member

adinauer commented Apr 11, 2024

While this might also report SDK bugs, it's most likely just an error going out through GraphQL errors.

It's being detected as a crash because the integration creates the RuntimeException as there's no throwable to wrap but just a message. We should ignore the exception for crash detection.

There's multiple things we could use to ignore it:

  • A:
"mechanism": {
          "type": "GraphqlInstrumentation",
          "handled": false
        }
  • B: last SDK stack trace frame
{
	"function": "lambda$instrumentExecutionResult$0",
	"module": "io.sentry.graphql.SentryInstrumentation",
	"filename": "SentryInstrumentation.java",
}

Most likely B is what we want. The name of the function might change but that shouldn't happen often - we should document this next to the function. For existing releases of the SDK we'll have to ignore as mentioned above. Where we create the exception should probably be separated out into each own function so it's even less likely to change over time then ignore whatever the name is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Discussion
Development

No branches or pull requests

2 participants