feat(tracing): Add line information from tracing #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 3, 2022 17:32
This adds the line information that tracing provides back into the event. It also moves around the tags into a custom context instead of the "extra" grab-bag as this is less likely to step on the user's ad-hoc toes.
loewenheim
approved these changes
Feb 3, 2022
Swatinem
approved these changes
Feb 3, 2022
flub
commented
Feb 4, 2022
There was a problem hiding this comment.
There are like lots more weird edge cases that i just don't understand what tracing is doing - which is why there's no test for the empty tags. I'm giving up though as this seems hopeless, I think the current implementation gives some useful information so I'm going to close my eyes and click merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the line information that tracing provides back into the
event. It also moves around the tags into a custom context instead of
the "extra" grab-bag as this is less likely to step on the user's
ad-hoc toes.
Related to #427