aisleriot: Remove dependency on pysolfc(-cardsets) #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** The PySol cardsets use a different style and thus don't really fit in with the rest. Additionally this saves more than 100 MB in combined install size, if you only install `aisleriot` Resolves getsolus#2516 Signed-off-by: Thomas Staudinger <Staudi.Kaos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PySol cardsets use a different style and thus don't really fit in with the rest.
Additionally this saves more than 100 MB in combined install size, if you only install
aisleriotResolves #2516
Test Plan
Switched through the remaining card styles; played a round of Klondike
Checklist