Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m4.js : Possible mistake in Orthographic's documentation #106

Open
2ndwolf opened this issue Jul 30, 2017 · 0 comments
Open

m4.js : Possible mistake in Orthographic's documentation #106

2ndwolf opened this issue Jul 30, 2017 · 0 comments

Comments

@2ndwolf
Copy link

2ndwolf commented Jul 30, 2017

Computes a 4-by-4 orthographic projection matrix given the coordinates of the
planes defining the axis-aligned, box-shaped viewing volume. The matrix
generated sends that box to the unit box. Note that although left and right
are x coordinates and bottom and top are y coordinates, near and far
are not z coordinates, but rather they are distances along the negative
z-axis. We assume a unit box extending from -1 to 1 in the x and y
dimensions and from -1 to 1 in the z dimension.

There may be a mistake here, if z dimension used the same unit box as x and y wouldn't we have a phrase more like "We assume a unit box extending from -1 to 1 in the x, y and z dimensions"?

From reading the rest, it probably was meant to be:
We assume a unit box extending from -1 to 1 in the x and y dimensions and from -1 to 0 in the z dimension.

Same goes for frustum's description.

@2ndwolf 2ndwolf changed the title m4.js Orthographic's description m4.js : Possible mistake in Orthographic's documentation Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant