Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement axes and iterate #5

Open
giordano opened this issue May 16, 2022 · 6 comments
Open

Implement axes and iterate #5

giordano opened this issue May 16, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@giordano
Copy link
Owner

This package currently implements only the basic AbstractArray interface, but not the optional methods such as iterate or axes, which leads to some funny (and wrong) results.

@giordano giordano added the enhancement New feature or request label May 16, 2022
@giordano
Copy link
Owner Author

Mostly addressed by f1e687f, 4f90098, and fe8a413. The main remaining issue I see is that now collect(::StarWarsArray) fails (it didn't use to up to 8e41eef)

@mkitti
Copy link

mkitti commented May 30, 2022

axes is supposed to return

a tuple of AbstractUnitRange{<:Integer} of valid indices

@giordano
Copy link
Owner Author

How do you think you can do a AbstractUnitRange{<:Integer} for this indexing?

@mkitti
Copy link

mkitti commented May 31, 2022

@mkitti
Copy link

mkitti commented May 31, 2022

I suppose that axes only has to return valid indices. They do not have to be in iteration order.

@jariji
Copy link

jariji commented Feb 12, 2024

They do not have to be in iteration order.

Can't we just add that requirement to the AbstractArray docs? It seems like a complication and I'm not seeing much advantage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants