Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't test against snakeoil website #355

Open
openbrian opened this issue Nov 10, 2015 · 5 comments
Open

Can't test against snakeoil website #355

openbrian opened this issue Nov 10, 2015 · 5 comments

Comments

@openbrian
Copy link

It would be nice if the user could set a context for the file_get_contents() call in RemoteCoverage.php. This way they could create a context that sets verify_peer and verify_peer_name to false. This error is silently ignored due to @.

@openbrian openbrian changed the title Cam Can't test against snakeoil website Nov 10, 2015
@robgudgeon
Copy link

Agreed. This is an issue with quite a number of vendor SDKs that I use, especially since php-5.6

@giorgiosironi
Copy link
Owner

The way I would solve this in general is to use a HTTP request library, but here we are trying to keep dependencies to a minimum so the proposed solution.
I will merge a Pull Request adding this support, the test Tests_Selenium2TestCase_Coverage_RemoteCoverageTest should be extended to deal with this feature.

@openbrian
Copy link
Author

Would you prefer a implicit stream context (http://php.net/manual/en/function.stream-context-set-default.php) or an explicit one like this file_get_contents($url, false, $streamContext) ?

@giorgiosironi
Copy link
Owner

The first one implies global state so the second is better imho.

@openbrian
Copy link
Author

See #360.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants