Opens diff tool when trying to select files to stage

[KaGeN101]

Each time I try and select a file to stage my diff tool opens first and then when I close it the file I am trying to select to stage is selected.
This is really annoying each time I click on a file to highlight it the diff tool first opens

OS: Ubuntu 10.04
cola version 1.4.1.2

[KaGeN101]

Please note this is only when the external diff tool is setup with a bash script through
diff.external.
Will check if I can get it working with diff..cmd and then update here.

[KaGeN101]

I can now confirm that when setting up:
git config diftool.[too].cmd as the preferred method to access the diff tool git-cola operates as expected.

[davvid]

we should probably be calling "git diff --no-ext-diff" to guard ourselves cos it's the combination of your diff.external setting, maybe?

I'm curious about the ~/.gitconfig entries. Can you post the relevent diff and difftool sections? I would not expect difftool.tool.cmd to make a difference.

[davvid]

gitcmds: Centralize diff options to guard against diff.external

Refactor usage of 'git diff' to pass '--no-ext-diff'.
Avoid launching user-configured diff.external viewers by updating
the _common_diff_opts() function and ensuring that all git.diff
callers use it.

Closed by 121f0ae

Signed-off-by: David Aguilar <davvid@gmail.com>