Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail under non-English locale #35

Open
eserte opened this issue Apr 25, 2015 · 3 comments
Open

Tests fail under non-English locale #35

eserte opened this issue Apr 25, 2015 · 3 comments

Comments

@eserte
Copy link

eserte commented Apr 25, 2015

On a system with German locale I see following errors:

    #   Failed test 'We created a tag because there wasn't one already'
    #   at t/run.t line 25.
    #                   ''
    #     doesn't match '(?^:debug)'

    #   Failed test 'We print a notice about the deploy being started'
    #   at t/run.t line 26.
    #                   '# FATAL: working directory not clean. git status reports:
    # # FATAL: Auf Branch master
    # # FATAL: Ihr Branch ist auf dem selben Stand wie 'origin/master'.
    # # FATAL: nichts zu committen, Arbeitsverzeichnis unverändert
    # Died at /home/cpansand/.cpan/build/git-deploy-6.01-jdN6VD/bin/git-deploy line 45.
    # '
    #     doesn't match '(?^:Deploy procedure has started)'

    #   Failed test 'By default we don't send mail on 'start''
    #   at t/run.t line 27.
    #                   '# FATAL: working directory not clean. git status reports:
    # # FATAL: Auf Branch master
    # # FATAL: Ihr Branch ist auf dem selben Stand wie 'origin/master'.
    # # FATAL: nichts zu committen, Arbeitsverzeichnis unverändert
    # Died at /home/cpansand/.cpan/build/git-deploy-6.01-jdN6VD/bin/git-deploy line 45.
    # '
    #     doesn't match '(?^:Not sending mail on action)'

etc. (It's not clear if the problem is really related to the locale, but non-English git messages are possibly problematic anyway)

avar added a commit that referenced this issue Apr 25, 2015
@avar
Copy link
Member

avar commented Apr 25, 2015

Thanks for the report. I don't have an environment here right now where I can test git-deploy with its translations, but the above commit in theory fixes this. Does the latest master branch work for you now?

@eserte
Copy link
Author

eserte commented Apr 26, 2015

dzil test does not work on my systems:

$ /usr/perl5.20.2p/bin/dzil test          
Can't decode ill-formed UTF-8 octet sequence <C6> at /usr/perl5.20.2p/lib/site_perl/5.20.2/Config/INI/Reader.pm line 97.

Given that perl t/run.t is more-or-less equivalent, then there's no more failure with master.

@eserte
Copy link
Author

eserte commented Apr 26, 2015

After removing your name from dist.ini dzil test was working, and run without errors, using the de_DE.ISO8859-1 locale.

zakame added a commit to zakame/git-deploy that referenced this issue Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants