Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision graph broken (regression) #11700

Open
pmiossec opened this issue Apr 23, 2024 · 4 comments · Fixed by #11714
Open

Revision graph broken (regression) #11700

pmiossec opened this issue Apr 23, 2024 · 4 comments · Fixed by #11714
Assignees
Milestone

Comments

@pmiossec
Copy link
Member

Environment

  • GitExtensions version: master ( 0b74e26 )

Issue description

At least on repository opening (I don't know if it could happen during a refresh)
it seems only when the repo has unrelated histories (but not sure)
the graph is broken:

image

instead of expected:

image

Refreshing the repository seems to make the bug disappear...

Steps to reproduce

No clear steps:

  1. switching from repos with unrelated histories increase the probability to get the bug

Did this work in previous version of GitExtensions?

Bisected to 609e03d, so yes, before

Diagnostics

Handling of e.Handled is too aggressive?

@pmiossec
Copy link
Member Author

@mstv I can make a PR to revert to my previous version of the optimization that don't introduce the regression.
Or you would like to investigate?

@mstv
Copy link
Member

mstv commented Apr 23, 2024

I have seen similar artifacts, too, mostly after rebase operations. I had two suspects: the commit identified by you or #11205.

I can make a PR to revert to my previous version of the optimization that don't introduce the regression. Or you would like to investigate?

That variant had other issues.

I think this will be resolved by the planned graph rendering in the background. Give me a few weeks for this rewrite, please.
If you think, the issue is too severe, just revert the commit.

@mstv
Copy link
Member

mstv commented May 1, 2024

Try it with #11718 and #11719, please.

@mstv mstv reopened this May 1, 2024
@pmiossec
Copy link
Member Author

pmiossec commented May 2, 2024

Try it with #11718 and #11719, please.

I think it fixes the issue. Well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants